Re: [Qemu-block] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

[Vladimir Sementsov-Ogievskiy]

03.04.2018 16:36, Kevin Wolf wrote:
> Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > Blacklist these formats, as they don't support image creation, as they
> > say:
> >      > ./qemu-img create -f bochs x 1m
> >      qemu-img: x: Format driver 'bochs' does not support image creation
> >
> >      > ./qemu-img create -f cloop x 1m
> >      qemu-img: x: Format driver 'cloop' does not support image creation
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> We can take this for now, but I think I would actually prefer a solution
> like in the bash tests, where the $IMGFMT_GENERIC environment variable
> is checked for "_supported_fmt generic".
>
> I suppose in Python test cases, we can assume that generic is meant when
> neither supported_fmts nor unsupported_fmts are given (or both are empty
> lists).
>
> Kevin

it may be ok for verify_image_format, as we can call it or not call (to 
support all formats).

but iotests main function always call verify_image_format, so, this will 
skip bochs and cloop for all
iotests which call maind() without format restriction.

So, I think it is safer to directly mimic bash tests behavior - allow 
'generic' as a member of supported_fmts.

--
Best regards,
Vladimir