Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 169

[Vladimir Sementsov-Ogievskiy]

11.04.2018 19:11, Max Reitz wrote:
> On 2018-04-11 15:05, Vladimir Sementsov-Ogievskiy wrote:
>
> [...]
>
> > Hmm, first type? I'm now not sure about, did I really see sha256
> > mismatch, or something like this (should be error, but found bitmap):
> >
> > --- /work/src/qemu/up-169/tests/qemu-iotests/169.out    2018-04-11
> > 15:35:10.055027392 +0300
> > +++ /work/src/qemu/up-169/tests/qemu-iotests/169.out.bad 2018-04-11
> > 15:58:09.300450045 +0300
> > @@ -1,5 +1,20 @@
> > -........
> > +F.......
> > +======================================================================
> > +FAIL: test__not_persistent__migbitmap__offline
> > (__main__.TestDirtyBitmapMigration)
> > +methodcaller(name, ...) --> methodcaller object
> > +----------------------------------------------------------------------
> > +Traceback (most recent call last):
> > +  File "169", line 136, in do_test_migration
> > +    self.check_bitmap(self.vm_b, sha256 if persistent else False)
> > +  File "169", line 77, in check_bitmap
> > +    "Dirty bitmap 'bitmap0' not found");
> > +  File "/work/src/qemu/up-169/tests/qemu-iotests/iotests.py", line 389,
> > in assert_qmp
> > +    result = self.dictpath(d, path)
> > +  File "/work/src/qemu/up-169/tests/qemu-iotests/iotests.py", line 348,
> > in dictpath
> > +    self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
> > +AssertionError: failed path traversal for "error/desc" in "{u'return':
> > {u'sha256':
> > u'01d2ebedcb8f549a2547dbf8e231c410e3e747a9479e98909fc936e0035cf8b1'}}"
> >
> >
> > Max, did you really seed sha256 mismatch or only something like this?
> I'm pretty sure I did see mismatches.

hm, may be it possible too, because of not waiting for RESUME in this 
case, we can request sha256 in the intermediate state of bitmap loading

> Max


--
Best regards,
Vladimir