Re: [Qemu-block] [PATCH v4 06/13] block: Generalize should_update_child() rule

[Max Reitz]

On 2018-04-20 10:36, Alberto Garcia wrote:
> On Wed 11 Apr 2018 08:54:18 PM CEST, Max Reitz wrote:
>> index c4dd1d4bb8..8d63a1b0c1 100644
>> --- a/include/block/block_int.h
>> +++ b/include/block/block_int.h
>> @@ -616,6 +616,8 @@ struct BdrvChild {
>>      QLIST_ENTRY(BdrvChild) next_parent;
>>  };
>>  
>> +typedef QLIST_HEAD(BdrvChildList, BdrvChild) BdrvChildList;
>> +
> 
> I forgot to mention this in a previous e-mail, but what's this used for?

Extremely good question.  grep says it isn't used for anything.  I'm
inclined to believe grep (especially considering the fact that
everything compiles without error after removing it).

I suppose I had some local version where I needed such a type (probably
because I didn't deem QLIST_FOREACH_SAFE() to be sufficiently safe, so I
needed to copy the list somewhere else, or I don't know...), and then I
found a way around it, removed the code, but forgot the type in the header.

Will remove in v5.


Thank you for reviewing!

Max

signature.asc
Description: OpenPGP digital signature