[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 01/17] block: iterate_format with a
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 01/17] block: iterate_format with account of whitelisting |
|
Date: |
Thu, 26 Apr 2018 13:15:13 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/26/2018 11:19 AM, Roman Kagan wrote:
> bdrv_iterate_format (which is currently only used for printing out the
> formats supported by the block layer) doesn't take format whitelisting
> into account.
>
> As a result, QEMU lies when asked for the list of block drivers it
> supports with "-drive format=?": some of the formats there may be
> recognized by qemu-* tools but unusable in qemu proper.
>
> To avoid that, exclude formats that are not whitelisted from
> enumeration, if whitelisting is in use. Since we have separate
> whitelists for r/w and r/o, take this as a parameter to
> bdrv_iterate_format, and print two lists of supported formats (r/w and
> r/o) in main qemu.
>
> Signed-off-by: Roman Kagan <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 00/17] iotests: don't choke on disabled drivers, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 03/17] iotests: ask qemu for supported formats, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 04/17] iotest 030: skip quorum test setup/teardown too, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 05/17] iotest 030: require blkdebug, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 02/17] iotests: iotests.py: prevent deadlock in subprocess, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 01/17] block: iterate_format with account of whitelisting, Roman Kagan, 2018/04/26
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/17] block: iterate_format with account of whitelisting,
Eric Blake <=
- [Qemu-block] [PATCH 11/17] iotest 087: notrun if null-co is disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 12/17] iotest 093: notrun if null-co or null-aio is disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 14/17] iotest 124: skip testcases using blkdebug if disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 09/17] iotest 071: notrun if blkdebug or blkverify is disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 08/17] iotest 056: skip testcases using blkdebug if disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 10/17] iotest 081: notrun if quorum is disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 07/17] iotest 055: require blkdebug, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 16/17] iotest 147: notrun if nbd is disabled, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 06/17] iotest 055: skip unsupported backup target formats, Roman Kagan, 2018/04/26
- [Qemu-block] [PATCH 15/17] iotest 139: skip testcases using disabled drivers, Roman Kagan, 2018/04/26