Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion

[Eric Blake]

On 04/28/2018 11:34 AM, Max Reitz wrote:
> This adds a test for an I/O error during snapshot deletion, and maybe
> more importantly, for how to repair the resulting image.  If the
> snapshot has been deleted before the error occurs, the only negative
> result will be leaked clusters -- and those should be repairable with
> qemu-img check -r leaks.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   tests/qemu-iotests/217     | 89 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/217.out | 42 ++++++++++++++++++++++
>   tests/qemu-iotests/group   |  1 +
>   3 files changed, 132 insertions(+)
>   create mode 100755 tests/qemu-iotests/217
>   create mode 100644 tests/qemu-iotests/217.out

> +
> +# Internal snapshots are (currently) impossible with refcount_bits=1
> +_unsupported_imgopts 'refcount_bits=1[^0-9]'
> +

And even if they are made possible (by cloning clusters instead of 
incrementing refcounts), you STILL need a refcount > 1 to test the 
particular repair functionality just fixed.

Up to you if you want to reword that comment a bit.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org