[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] blockjob: expose error string via query
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH] blockjob: expose error string via query |
|
Date: |
Wed, 09 May 2018 10:06:27 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 09 May 2018 01:36:59 AM CEST, John Snow wrote:
> When we've reached the concluded state, we need to expose the error
> state if applicable. Add the new field.
>
> This should be sufficient for determining if a job completed
> successfully or not after concluding; if we want to discriminate
> based on how it failed more mechanically, we can always add an
> explicit return code enumeration later.
>
> I didn't bother to make it only show up if we are in the concluded
> state; I don't think it's necessary.
>
> Signed-off-by: John Snow <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto