[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options |
Date: |
Wed, 9 May 2018 18:57:16 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/09/2018 05:00 PM, Max Reitz wrote:
> Looking at the qcow2 code that is riddled with error_report() calls,
> this is really how it should have been from the start.
>
> Along the way, turn the target_version/current_version comparisons at
> the beginning of qcow2_downgrade() into assertions (the caller has to
> make sure these conditions are met), and rephrase the error message on
> using compat=1.1 to get refcount widths other than 16 bits.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
address@hidden
- [Qemu-block] [PATCH v2 0/7] qemu-img: Improve option help for amend, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 3/7] qemu-option: Pull out "Supported options" print, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 1/7] qemu-img: Amendment support implies create_opts, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 4/7] qemu-img: Add print_amend_option_help(), Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 5/7] qemu-img: Recognize no creation support in -o help, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 6/7] iotests: Test help option for unsupporting formats, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 7/7] iotests: Rework 113, Max Reitz, 2018/05/09