[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 31/42] job: Move transactions to Job
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 31/42] job: Move transactions to Job |
Date: |
Mon, 14 May 2018 23:17:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-09 18:26, Kevin Wolf wrote:
> This moves the logic that implements job transactions from BlockJob to
> Job.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/block/blockjob.h | 54 ----------
> include/block/blockjob_int.h | 10 --
> include/qemu/job.h | 71 +++++++++++--
> blockdev.c | 6 +-
> blockjob.c | 238
> +------------------------------------------
> job.c | 235 ++++++++++++++++++++++++++++++++++++++++--
> tests/test-blockjob-txn.c | 12 +--
> tests/test-blockjob.c | 2 +-
> 8 files changed, 304 insertions(+), 324 deletions(-)
[...]
> diff --git a/job.c b/job.c
> index 49dce57c9e..2d782859ac 100644
> --- a/job.c
> +++ b/job.c
[...]
> @@ -263,9 +353,10 @@ void job_event_completed(Job *job)
> notifier_list_notify(&job->on_finalize_completed, job);
> }
>
> -void job_event_pending(Job *job)
> +static int job_event_pending(Job *job)
> {
> notifier_list_notify(&job->on_pending, job);
> + return 0;
> }
>
> void job_enter_cond(Job *job, bool(*fn)(Job *job))
On second thought, I don't know why this hunk is necessary.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 26/42] job: Convert block_job_cancel_async() to Job, (continued)
- [Qemu-block] [PATCH 26/42] job: Convert block_job_cancel_async() to Job, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 29/42] job: Move job_finish_sync() to Job, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 28/42] job: Move .complete callback to Job, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 30/42] job: Switch transactions to JobTxn, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 31/42] job: Move transactions to Job, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 34/42] job: Add job_dismiss(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 33/42] job: Add job_yield(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 32/42] job: Move completion and cancellation to Job, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 36/42] job: Add job_transition_to_ready(), Kevin Wolf, 2018/05/09