[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v9 1/9] mirror: inherit supported write/zero fla
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v9 1/9] mirror: inherit supported write/zero flags |
Date: |
Tue, 15 May 2018 09:35:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/08/2018 09:58 AM, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/mirror.c | 11 +++++++++++
1 file changed, 11 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
That said,
diff --git a/block/mirror.c b/block/mirror.c
index 820f512..a22ddef 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1098,6 +1098,15 @@ static BlockDriver bdrv_mirror_top = {
.bdrv_child_perm = bdrv_mirror_top_child_perm,
};
+static void mirror_top_set_supported_flags(BlockDriverState *bs)
+{
+ bs->supported_write_flags = BDRV_REQ_FUA &
+ bs->backing->bs->supported_write_flags;
+ bs->supported_zero_flags =
+ (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &
+ bs->backing->bs->supported_zero_flags;
+}
+
This is a pretty short static function...
static void mirror_start_job(const char *job_id, BlockDriverState *bs,
int creation_flags, BlockDriverState *target,
const char *replaces, int64_t speed,
@@ -1163,6 +1172,8 @@ static void mirror_start_job(const char *job_id,
BlockDriverState *bs,
return;
}
+ mirror_top_set_supported_flags(mirror_top_bs);
...with exactly one caller. Wouldn't it be easier to just inline it?
+
/* Make sure that the source is not resized while the job is running */
s = block_job_create(job_id, driver, NULL, mirror_top_bs,
BLK_PERM_CONSISTENT_READ,
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-block] [PATCH v9 0/9] qcow2: cluster space preallocation, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 1/9] mirror: inherit supported write/zero flags, Anton Nefedov, 2018/05/08
- Re: [Qemu-block] [PATCH v9 1/9] mirror: inherit supported write/zero flags,
Eric Blake <=
- [Qemu-block] [PATCH v9 2/9] blkverify: set supported write/zero flags, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 5/9] block: treat BDRV_REQ_ALLOCATE as serialising, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 3/9] quorum: set supported write/zero flags, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 6/9] file-posix: support BDRV_REQ_ALLOCATE, Anton Nefedov, 2018/05/08
- [Qemu-block] [PATCH v9 9/9] iotest 134: test cluster-misaligned encrypted write, Anton Nefedov, 2018/05/08