[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 06/16] ahci: modify ahci_port_write to use regist
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH v2 06/16] ahci: modify ahci_port_write to use register numbers |
Date: |
Thu, 31 May 2018 18:28:25 -0400 |
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 476841df58..efecf849a9 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -282,30 +282,32 @@ static int ahci_cond_start_engines(AHCIDevice *ad)
static void ahci_port_write(AHCIState *s, int port, int offset, uint32_t val)
{
AHCIPortRegs *pr = &s->dev[port].port_regs;
+ enum AHCIPortReg regnum = offset / sizeof(uint32_t);
+ assert(regnum < (AHCI_PORT_ADDR_OFFSET_LEN / sizeof(uint32_t)));
trace_ahci_port_write(s, port, offset, val);
- switch (offset) {
- case PORT_LST_ADDR:
+ switch (regnum) {
+ case AHCI_PORT_REG_LST_ADDR:
pr->lst_addr = val;
break;
- case PORT_LST_ADDR_HI:
+ case AHCI_PORT_REG_LST_ADDR_HI:
pr->lst_addr_hi = val;
break;
- case PORT_FIS_ADDR:
+ case AHCI_PORT_REG_FIS_ADDR:
pr->fis_addr = val;
break;
- case PORT_FIS_ADDR_HI:
+ case AHCI_PORT_REG_FIS_ADDR_HI:
pr->fis_addr_hi = val;
break;
- case PORT_IRQ_STAT:
+ case AHCI_PORT_REG_IRQ_STAT:
pr->irq_stat &= ~val;
ahci_check_irq(s);
break;
- case PORT_IRQ_MASK:
+ case AHCI_PORT_REG_IRQ_MASK:
pr->irq_mask = val & 0xfdc000ff;
ahci_check_irq(s);
break;
- case PORT_CMD:
+ case AHCI_PORT_REG_CMD:
/* Block any Read-only fields from being set;
* including LIST_ON and FIS_ON.
* The spec requires to set ICC bits to zero after the ICC change
@@ -329,26 +331,26 @@ static void ahci_port_write(AHCIState *s, int port, int
offset, uint32_t val)
check_cmd(s, port);
break;
- case PORT_TFDATA:
- case PORT_SIG:
- case PORT_SCR_STAT:
+ case AHCI_PORT_REG_TFDATA:
+ case AHCI_PORT_REG_SIG:
+ case AHCI_PORT_REG_SCR_STAT:
/* Read Only */
break;
- case PORT_SCR_CTL:
+ case AHCI_PORT_REG_SCR_CTL:
if (((pr->scr_ctl & AHCI_SCR_SCTL_DET) == 1) &&
((val & AHCI_SCR_SCTL_DET) == 0)) {
ahci_reset_port(s, port);
}
pr->scr_ctl = val;
break;
- case PORT_SCR_ERR:
+ case AHCI_PORT_REG_SCR_ERR:
pr->scr_err &= ~val;
break;
- case PORT_SCR_ACT:
+ case AHCI_PORT_REG_SCR_ACT:
/* RW1 */
pr->scr_act |= val;
break;
- case PORT_CMD_ISSUE:
+ case AHCI_PORT_REG_CMD_ISSUE:
pr->cmd_issue |= val;
check_cmd(s, port);
break;
--
2.14.3
- [Qemu-block] [PATCH v2 00/16] AHCI: tracing improvements, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 05/16] ahci: combine identical clauses in port write, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 01/16] ahci: add port register enumeration, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 08/16] ahci: delete old port register address definitions, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 03/16] ahci: make port read traces more descriptive, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 09/16] ahci: add host register enumeration, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 02/16] ahci: modify ahci_port_read to use register numbers, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 06/16] ahci: modify ahci_port_write to use register numbers,
John Snow <=
- [Qemu-block] [PATCH v2 07/16] ahci: make port write traces more descriptive, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 04/16] ahci: fix spacing damage on ahci_port_write, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 10/16] ahci: fix host register max address, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 11/16] ahci: modify ahci_mem_read_32 to work on register numbers, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 14/16] ahci: adjust ahci_mem_write to work on registers, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 15/16] ahci: delete old host register address definitions, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 12/16] ahci: make mem_read_32 traces more descriptive, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 13/16] ahci: fix spacing damage on ahci_mem_write, John Snow, 2018/05/31
- [Qemu-block] [PATCH v2 16/16] ahci: make ahci_mem_write traces more descriptive, John Snow, 2018/05/31
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements, no-reply, 2018/05/31