[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probi
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-block] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing |
Date: |
Tue, 12 Jun 2018 09:06:11 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Mon, Jun 11, 2018 at 10:51:57PM +0200, Max Reitz wrote:
> Currently, you can give no encryption format for a qcow2 file while
> still passing a key-secret. That does not conform to the schema, so
> this patch changes the schema to allow it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qapi/block-core.json | 44 ++++++++++++++++++++++++++++++++++++++++----
> block/qcow2.c | 3 +++
> 2 files changed, 43 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-block] [PATCH v2 00/10] block: Try to create well typed json:{} filenames, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 01/10] qapi: Add default-variant for flat unions, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 02/10] docs/qapi: Document optional discriminators, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 03/10] tests: Add QAPI optional discriminator tests, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 05/10] qapi: Formalize qcow encryption probing, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 07/10] tests: Add QDict clone-flatten test, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 06/10] qdict: Make qdict_flatten() shallow-clone-friendly, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 09/10] iotests: Test internal option typing, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 08/10] block: Try to create well typed json:{} filenames, Max Reitz, 2018/06/11
- [Qemu-block] [PATCH v2 10/10] iotests: qcow2's encrypt.format is now optional, Max Reitz, 2018/06/11