[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk is RO |
Date: |
Tue, 12 Jun 2018 22:06:09 -0400 |
For the purposes of qemu-img manipulation and querying of bitmaps, load
bitmaps that are "in use" -- if the image is read only. This will allow
us to diagnose problems with this flag using the qemu-img tool.
Signed-off-by: John Snow <address@hidden>
---
block/qcow2-bitmap.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 859819639b..6c4fe9b281 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -345,7 +345,7 @@ static BdrvDirtyBitmap *load_bitmap(BlockDriverState *bs,
uint32_t granularity;
BdrvDirtyBitmap *bitmap = NULL;
- if (bm->flags & BME_FLAG_IN_USE) {
+ if (can_write(bs) && (bm->flags & BME_FLAG_IN_USE)) {
error_setg(errp, "Bitmap '%s' is in use", bm->name);
goto fail;
}
@@ -976,23 +976,21 @@ bool qcow2_load_dirty_bitmaps(BlockDriverState *bs, Error
**errp)
}
QSIMPLEQ_FOREACH(bm, bm_list, entry) {
- if (!(bm->flags & BME_FLAG_IN_USE)) {
- BdrvDirtyBitmap *bitmap = load_bitmap(bs, bm, errp);
- if (bitmap == NULL) {
- goto fail;
- }
- bm->dirty_bitmap = bitmap;
+ BdrvDirtyBitmap *bitmap = load_bitmap(bs, bm, errp);
+ if (bitmap == NULL) {
+ goto fail;
+ }
+ bm->dirty_bitmap = bitmap;
- if (!(bm->flags & BME_FLAG_AUTO)) {
- bdrv_disable_dirty_bitmap(bitmap);
- }
- bdrv_dirty_bitmap_set_persistance(bitmap, true);
- if (can_write(bs)) {
- bm->flags |= BME_FLAG_IN_USE;
- needs_update = true;
- } else {
- bdrv_dirty_bitmap_set_readonly(bitmap, true);
- }
+ if (!(bm->flags & BME_FLAG_AUTO)) {
+ bdrv_disable_dirty_bitmap(bitmap);
+ }
+ bdrv_dirty_bitmap_set_persistance(bitmap, true);
+ if (can_write(bs)) {
+ bm->flags |= BME_FLAG_IN_USE;
+ needs_update = true;
+ } else {
+ bdrv_dirty_bitmap_set_readonly(bitmap, true);
}
}
--
2.14.3
- [Qemu-block] [PATCH v2 00/10] qemu-img: add bitmap info output, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk is RO,
John Snow <=
- [Qemu-block] [PATCH v2 07/10] qcow2/bitmap: track bitmap type, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 05/10] qcow2/bitmap: reject IN_USE bitmaps on rw reload, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 02/10] qcow2/bitmap: avoid adjusting bm->flags for RO bitmaps, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 04/10] qcow2/bitmap: cache loaded bitmaps, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 01/10] qcow2/bitmap: remove redundant arguments from bitmap_list_load, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 09/10] qapi: add bitmap info, John Snow, 2018/06/12
- [Qemu-block] [PATCH v2 03/10] qcow2/bitmap: cache bm_list, John Snow, 2018/06/12