[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 2/6] nbd/server: refactor NBDExportMetaContex
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 2/6] nbd/server: refactor NBDExportMetaContexts |
Date: |
Tue, 19 Jun 2018 14:03:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Use NBDExport pointer instead of just export name: there no needs to
s/no needs/is no need/
store duplicated name in the struct, moreover, NBDExport will be used
further.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
nbd/server.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
@@ -399,10 +399,9 @@ static int nbd_negotiate_handle_list(NBDClient *client,
Error **errp)
return nbd_negotiate_send_rep(client, NBD_REP_ACK, errp);
}
-static void nbd_check_meta_export_name(NBDClient *client)
+static void nbd_check_meta_export(NBDClient *client)
{
- client->export_meta.valid &= !strcmp(client->exp->name,
- client->export_meta.export_name);
+ client->export_meta.valid &= client->exp == client->export_meta.exp;
Changes from string comparison to pointer comparison...
@@ -853,15 +852,15 @@ static int nbd_negotiate_meta_queries(NBDClient *client,
memset(meta, 0, sizeof(*meta));
- ret = nbd_opt_read_name(client, meta->export_name, NULL, errp);
+ ret = nbd_opt_read_name(client, export_name, NULL, errp);
if (ret <= 0) {
return ret;
}
- exp = nbd_export_find(meta->export_name);
- if (exp == NULL) {
+ meta->exp = nbd_export_find(export_name);
+ if (meta->exp == NULL) {
...by remembering the results of the string comparison performed under
the hood. Looks good.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export, (continued)
Re: [Qemu-block] [PATCH v5 4/6] nbd/server: implement dirty bitmap export, Eric Blake, 2018/06/20
[Qemu-block] [PATCH v5 3/6] nbd/server: add nbd_meta_empty_or_pattern helper, Vladimir Sementsov-Ogievskiy, 2018/06/09
[Qemu-block] [PATCH v5 2/6] nbd/server: refactor NBDExportMetaContexts, Vladimir Sementsov-Ogievskiy, 2018/06/09
- Re: [Qemu-block] [PATCH v5 2/6] nbd/server: refactor NBDExportMetaContexts,
Eric Blake <=
[Qemu-block] [PATCH v5 1/6] nbd/server: fix trace, Vladimir Sementsov-Ogievskiy, 2018/06/09