[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] iotest: Fix filtering order in 226
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] iotest: Fix filtering order in 226 |
|
Date: |
Mon, 23 Jul 2018 15:55:38 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 13.07.2018 um 22:14 hat John Snow geschrieben:
>
>
> On 07/13/2018 03:41 PM, Max Reitz wrote:
> > The test directory should be filtered before the image format, otherwise
> > the test will fail if the image format is part of the test directory,
> > like so:
> >
> > [...]
> > -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
> > +can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': Is a directory
> > [...]
> >
> > Signed-off-by: Max Reitz <address@hidden>
>
> Too many gotchas in our test suite.
>
> Thanks :(
Maybe we should start writing tests for our tests? ;-)
Thanks, applied to the block branch.
Kevin