[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 19/21] qapi/block-commit: expose new job properties
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH 19/21] qapi/block-commit: expose new job properties |
Date: |
Tue, 7 Aug 2018 00:33:47 -0400 |
Signed-off-by: John Snow <address@hidden>
---
blockdev.c | 8 ++++++++
qapi/block-core.json | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index c2e6402a66..8efc47e178 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3314,6 +3314,8 @@ void qmp_block_commit(bool has_job_id, const char
*job_id, const char *device,
bool has_backing_file, const char *backing_file,
bool has_speed, int64_t speed,
bool has_filter_node_name, const char *filter_node_name,
+ bool has_auto_finalize, bool auto_finalize,
+ bool has_auto_dismiss, bool auto_dismiss,
Error **errp)
{
BlockDriverState *bs;
@@ -3333,6 +3335,12 @@ void qmp_block_commit(bool has_job_id, const char
*job_id, const char *device,
if (!has_filter_node_name) {
filter_node_name = NULL;
}
+ if (has_auto_finalize && !auto_finalize) {
+ job_flags |= JOB_MANUAL_FINALIZE;
+ }
+ if (has_auto_dismiss && !auto_dismiss) {
+ job_flags |= JOB_MANUAL_DISMISS;
+ }
/* Important Note:
* libvirt relies on the DeviceNotFound error class in order to probe for
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5b9084a394..4ee58cfb28 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1518,7 +1518,8 @@
{ 'command': 'block-commit',
'data': { '*job-id': 'str', 'device': 'str', '*base': 'str', '*top': 'str',
'*backing-file': 'str', '*speed': 'int',
- '*filter-node-name': 'str' } }
+ '*filter-node-name': 'str',
+ '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
##
# @drive-backup:
--
2.14.4
- Re: [Qemu-block] [PATCH 02/21] jobs: add exit shim, (continued)
[Qemu-block] [PATCH 06/21] block/stream: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-block] [PATCH 10/21] tests/test-bdrv-drain: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-block] [PATCH 20/21] qapi/block-mirror: expose new job properties, John Snow, 2018/08/07
[Qemu-block] [PATCH 12/21] jobs: allow entrypoints to return status code, John Snow, 2018/08/07
[Qemu-block] [PATCH 19/21] qapi/block-commit: expose new job properties,
John Snow <=
[Qemu-block] [PATCH 15/21] block/stream: add block job creation flags, John Snow, 2018/08/07
[Qemu-block] [PATCH 11/21] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/07
[Qemu-block] [PATCH 14/21] block/mirror: add block job creation flags, John Snow, 2018/08/07
[Qemu-block] [PATCH 16/21] block/commit: refactor commit to use job callbacks, John Snow, 2018/08/07