[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 4/5] qcow2: Set the default cache-clean-inter

From: Leonid Bloch
Subject: Re: [Qemu-block] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes
Date: Thu, 9 Aug 2018 13:52:34 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 8/9/18 12:33 PM, Alberto Garcia wrote:
On Thu 09 Aug 2018 12:11:37 AM CEST, Leonid Bloch wrote:
The default cache-clean-interval is set to 10 minutes, in order to lower
the overhead of the qcow2 caches (before the default was 0, i.e.

Signed-off-by: Leonid Bloch <address@hidden>

--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2830,7 +2830,8 @@
  # @cache-clean-interval:  clean unused entries in the L2 and refcount
  #                         caches. The interval is in seconds. The default 
-#                         is 0 and it disables this feature (since 2.5)
+#                         is 600. Setting 0 disables this feature. (since 2.5)

It should be "Setting it to 0 ...".

How about:

"... is 600 (0 disables this feature). (since 2.5)"?

... To avoid the extra line. That's why I skipped the "it to" as well. Alternatively, maybe we can skip the defaults altogether in this file, just as with all the other qcow2 options there?


With that corrected,

Reviewed-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]