[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 2/2] qemu-iotests: Test commit with top-node/bas

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 2/2] qemu-iotests: Test commit with top-node/base-node
Date: Fri, 10 Aug 2018 12:36:02 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 08/10/2018 11:26 AM, Kevin Wolf wrote:
This adds some tests for block-commit with the new options top-node and
base-node (taking node names) instead of top and base (taking file

May need a rewrite if you like my idea of "by-node":true.

Signed-off-by: Kevin Wolf <address@hidden>
  tests/qemu-iotests/040     | 52 ++++++++++++++++++++++++++++++++++++++++++++--
  tests/qemu-iotests/040.out |  4 ++--
  2 files changed, 52 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 1beb5e6dab..1cb1ceeb33 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests/040
@@ -57,9 +57,12 @@ class ImageCommitTestCase(iotests.QMPTestCase):
- def run_commit_test(self, top, base, need_ready=False):
+    def run_commit_test(self, top, base, need_ready=False, node_names=False):

Especially since you've already picked that style of signature here :)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]