[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to

From: Leonid Bloch
Subject: Re: [Qemu-block] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to the image size
Date: Mon, 13 Aug 2018 14:48:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 8/13/18 2:33 PM, Kevin Wolf wrote:
Am 11.08.2018 um 21:19 hat Leonid Bloch geschrieben:
   @item refcount-cache-size
   The maximum size of the refcount block cache in bytes
diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137
index 87965625d8..e3fb078588 100755
--- a/tests/qemu-iotests/137
+++ b/tests/qemu-iotests/137
@@ -109,7 +109,6 @@ $QEMU_IO \
       -c "reopen -o cache-size=1M,l2-cache-size=64k,refcount-cache-size=64k" \
       -c "reopen -o cache-size=1M,l2-cache-size=2M" \
       -c "reopen -o cache-size=1M,refcount-cache-size=2M" \
-    -c "reopen -o l2-cache-size=256T" \

The "L2 cache size too big" error can still be tested, but you will need
to create an image large enough to allow such a big cache.

$ qemu-img create -f qcow2 -o cluster_size=256k hd.qcow2 32P
$ $QEMU -drive file=hd.qcow2,l2-cache-entry-size=512,l2-cache-size=1T

* 32P qcow2 will take 33M - is it OK to create it just for a test?
* Is it worth to create a special test scenario, with a separate image
creation, just for that case?

We're creating larger images than that during tests, so I think this is
fine. You don't have to create a new separate test file or anything,
just increase the size of the used test image from 64M to 32P or
whatever is necessary.

OK, sure, will do in v9.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]