[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perf

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perform()
Date: Mon, 13 Aug 2018 17:21:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-08-13 16:43, Paolo Bonzini wrote:
> On 13/08/2018 04:19, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
> Locking AioContext should not be needed anywhere here.  mirror_run is
> called via aio_co_enter or aio_co_wake, so the lock is actually already
> taken every time you call aio_context_acquire.
> It was needed only because AIO callbacks do *not* take the lock, but
> it's not needed anymore since the conversion to coroutines.

Uh, nice.  Thanks for letting me know! :-)

I'll drop the locks in v2.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]