[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/5] Some bs->options fixes

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 0/5] Some bs->options fixes
Date: Tue, 14 Aug 2018 16:04:03 +0200
User-agent: Mutt/1.9.1 (2017-09-22)

Am 29.06.2018 um 13:36 hat Alberto Garcia geschrieben:
> Hi everyone,
> this is part of the blockdev-reopen work that I'm doing, but since
> I'll be away during most of July I thought that I could send already a
> couple of patches that I think are ready and don't need anything else
> from the rest of the series.
> There's two main fixes here:
>   1) bs->options are not kept up to date after an image is reopened
>      and no longer reflect its state.
>   2) bs->options and bs->explicit_options also contain the options of
>      a BDS's children, so there's data that is duplicated and will be
>      inconsistent as soon as you change the children's options
>      directly.
> The fix for (2) involves removing all children options from both
> QDicts. In the cases of node name references ("backing": "node-name")
> those remain in the QDict (they're technically parent options). I
> think we don't really need them and it should be possible to get rid
> of them, but it's a little more complicated (we need them during
> bdrv_reopen() to ensure that the user didn't try to change any of
> them).

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]