Re: [Qemu-block] [PATCH 5/7] block/mirror: utilize job_exit shim

[Max Reitz]

On 2018-08-17 21:04, John Snow wrote:
> Change the manual deferment to mirror_exit into the implicit
> callback to job_exit and the mirror_exit callback.
> 
> This does change the order of some bdrv_unref calls and job_completed,
> but thanks to the new context in which we call .job_exit, this is safe
> to defer the possible flushing of any nodes to the job_finalize_single
> cleanup stage.
> 
> Signed-off-by: John Snow <address@hidden>
> ---
>  block/mirror.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)

Looks OK, but the same comment from the previous patch applies (I
wouldn't throw 'ret' around and instead work with just a boolean that
signifies failure or success.  Also, you might even want to remove
s->ret because the Error object should be enough, actually.)

Max

signature.asc
Description: OpenPGP digital signature