[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 8/9] block: Allow changing 'detect-zeroes' on re

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen
Date: Wed, 29 Aug 2018 13:52:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-08-26 16:09, Alberto Garcia wrote:
> 'detect-zeroes' is one of the basic BlockdevOptions available for all
> drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so
> the user cannot change it and doesn't get an error explaining that it
> can't be changed.
> This should update the detect-zeroes setting, but does nothing:
>    (qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
> This should return an error but also does nothing:
>    (qemu) qemu-io virtio0 "reopen -o discard=off,detect-zeroes=unmap"
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c               | 63 
> +++++++++++++++++++++++++++++++--------------------
>  include/block/block.h |  1 +
>  2 files changed, 40 insertions(+), 24 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]