[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 8/9] jobs: remove ret argument to job_complet

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v3 8/9] jobs: remove ret argument to job_completed; privatize it
Date: Fri, 31 Aug 2018 15:25:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-08-30 03:57, John Snow wrote:
> Jobs are now expected to return their retcode on the stack, from the
> .run callback, so we can remove that argument.
> job_cancel does not need to set -ECANCELED because job_completed will
> update the return code itself if the job was canceled.
> While we're here, make job_completed static to job.c and remove it from
> job.h; move the documentation of return code to the .run() callback and
> to the job->ret property, accordingly.
> Signed-off-by: John Snow <address@hidden>
> ---
>  include/qemu/job.h | 28 +++++++++++++++-------------
>  job.c              | 11 ++++++-----
>  trace-events       |  2 +-
>  3 files changed, 22 insertions(+), 19 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]