[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 16/16] blockdev: document transactional short
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH v5 16/16] blockdev: document transactional shortcomings |
Date: |
Thu, 6 Sep 2018 13:03:34 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Sep 06, 2018 at 09:02:25AM -0400, John Snow wrote:
> Presently only the backup job really guarantees what one would consider
> transactional semantics. To guard against someone helpfully adding them
> in the future, document that there are shortcomings in the model that
> would need to be audited at that time.
>
> Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> blockdev.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 0cf8febe6c..d4b42403df 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2182,7 +2182,13 @@ static const BlkActionOps actions[] = {
> .instance_size = sizeof(BlockDirtyBitmapState),
> .prepare = block_dirty_bitmap_disable_prepare,
> .abort = block_dirty_bitmap_disable_abort,
> - }
> + },
> + /* Where are transactions for MIRROR, COMMIT and STREAM?
> + * Although these blockjobs use transaction callbacks like the backup
> job,
> + * these jobs do not necessarily adhere to transaction semantics.
> + * These jobs may not fully undo all of their actions on abort, nor do
> they
> + * necessarily work in transactions with more than one job in them.
> + */
> };
>
> /**
> --
> 2.14.4
>
- Re: [Qemu-block] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks, (continued)
- [Qemu-block] [PATCH v5 11/16] jobs: remove .exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 09/16] tests/test-blockjob: remove exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 07/16] block/stream: refactor stream to use job callbacks, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 13/16] qapi/block-mirror: expose new job properties, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 16/16] blockdev: document transactional shortcomings, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 08/16] tests/blockjob: replace Blockjob with Job, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 15/16] block/backup: qapi documentation fixup, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 12/16] qapi/block-commit: expose new job properties, John Snow, 2018/09/06
- Re: [Qemu-block] [PATCH v5 00/16] jobs: Job Exit Refactoring Pt 2, Max Reitz, 2018/09/07