Re: [Qemu-block] [Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

[Max Reitz]

On 2018-09-06 22:31, John Snow wrote:
> 
> 
> On 09/06/2018 12:57 PM, Jeff Cody wrote:
>> On Thu, Sep 06, 2018 at 09:02:15AM -0400, John Snow wrote:
>>> For purposes of minimum code movement, refactor the mirror_exit
>>> callback to use the post-finalization callbacks in a trivial way.
>>>
>>> Signed-off-by: John Snow <address@hidden>
>>> ---
>>>  block/mirror.c | 39 ++++++++++++++++++++++++++++-----------
>>>  1 file changed, 28 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/block/mirror.c b/block/mirror.c
>>> index bd3e908710..a92b4702c5 100644
>>> --- a/block/mirror.c
>>> +++ b/block/mirror.c
>>> @@ -79,6 +79,7 @@ typedef struct MirrorBlockJob {
>>>      int max_iov;
>>>      bool initial_zeroing_ongoing;
>>>      int in_active_write_counter;
>>> +    bool prepared;
>>>  } MirrorBlockJob;
>>>  
>>>  typedef struct MirrorBDSOpaque {
>>> @@ -607,7 +608,7 @@ static void mirror_wait_for_all_io(MirrorBlockJob *s)
>>>      }
>>>  }
>>>  
>>> -static void mirror_exit(Job *job)
> 
> /**
>  * mirror_exit_common: handle both abort() and prepare() cases.
>  * for .prepare, returns 0 on success and -errno on failure.
>  * for .abort cases, denoted by abort = true, MUST return 0.
>  */

Any case:

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature