[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 06/17] job: Use AIO_WAIT_WHILE() in job_finis
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v2 06/17] job: Use AIO_WAIT_WHILE() in job_finish_sync() |
|
Date: |
Thu, 13 Sep 2018 19:39:26 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 13.09.2018 um 17:15 hat Paolo Bonzini geschrieben:
> On 13/09/2018 14:52, Kevin Wolf wrote:
> > Also, job_drain() without aio_poll() isn't necessarily enough to make
> > progress on a job, it could depend on bottom halves to be executed.
>
> This is not changed by the patch though; AIO_WAIT_WHILE does not do the
> bottom halves part anymore, bdrv_drain_poll_top_level does it instead.
>
> What is it that needs bottom halves to be executed? Could it delay
> switching the job state until after that?
AIO_WAIT_WHILE() does still execute bottom halves if the condition is
true, which is all that is needed to make progress. It only doesn't
execute them unconditionally any more.
Kevin
- Re: [Qemu-block] [PATCH v2 02/17] blockjob: Wake up BDS when job becomes idle, (continued)
- [Qemu-block] [PATCH v2 04/17] test-bdrv-drain: Drain with block jobs in an I/O thread, Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 05/17] test-blockjob: Acquire AioContext around job_cancel_sync(), Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 06/17] job: Use AIO_WAIT_WHILE() in job_finish_sync(), Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 08/17] block: Add missing locking in bdrv_co_drain_bh_cb(), Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 09/17] block-backend: Add .drained_poll callback, Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 07/17] test-bdrv-drain: Test AIO_WAIT_WHILE() in completion callback, Kevin Wolf, 2018/09/13
- [Qemu-block] [PATCH v2 10/17] block-backend: Fix potential double blk_delete(), Kevin Wolf, 2018/09/13