[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v9 8/9] qcow2: Set the default cache-clean-inter
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes |
Date: |
Fri, 21 Sep 2018 14:35:38 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote:
> /* New interval for cache cleanup timer */
> r->cache_clean_interval =
> qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL,
> - s->cache_clean_interval);
> + DEFAULT_CACHE_CLEAN_INTERVAL);
I just realized we're ignoring the old value (s->cache_clean_interval)
here. What's the consequence of this? (this was a change made by Kevin
Wolf in 5b0959a7d432062dcd740f8065004285b15695fa).
> #ifndef CONFIG_LINUX
> if (r->cache_clean_interval != 0) {
> error_setg(errp, QCOW2_OPT_CACHE_CLEAN_INTERVAL
> " not supported on this host");
Another thing that I noticed (see below)...
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0f0e3534bf..8c863897b0 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -82,6 +82,7 @@
>
> #define DEFAULT_CLUSTER_SIZE S_64KiB
>
> +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */
Shouldn't this be set to 0 in non-Linux platforms? Otherwise it will try
to set it to 600 by default in all platforms and will complain with the
"not supported on this host" error message that I quoted above.
Berto
- [Qemu-block] [PATCH v9 1/9] qcow2: Options' documentation fixes, (continued)
- [Qemu-block] [PATCH v9 1/9] qcow2: Options' documentation fixes, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 2/9] include: Add a lookup table of sizes, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 4/9] qcow2: Avoid duplication in setting the refcount cache size, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 7/9] qcow2: Resize the cache upon image resizing, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 9/9] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 6/9] qcow2: Increase the default upper limit on the L2 cache size, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/09/18
- [Qemu-block] [PATCH v9 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/09/18