[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] option: Make option help nicer
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] option: Make option help nicer to read |
|
Date: |
Fri, 19 Oct 2018 12:00:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 17.10.18 08:50, Markus Armbruster wrote:
> Max Reitz <address@hidden> writes:
>
>> This adds some whitespace into the option help (including indentation)
>> and replaces '=' by ': ' (not least because '=' should be used for
>> values, not types). Furthermore, the list name is no longer printed as
>> part of every line, but only once in advance, and only if the caller did
>> not print a caption already.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> include/qemu/option.h | 2 +-
>> qemu-img.c | 4 +-
>> util/qemu-option.c | 31 +-
>> tests/qemu-iotests/082.out | 956 ++++++++++++++++++-------------------
>> 4 files changed, 505 insertions(+), 488 deletions(-)
>
> 082 fails for me in master (dddb37495b8). If this patch fixes the
> failure, its commit message should mention it.
Ah, yeah, totally forgot that...
Max
> 091 and 142 also fail, but look unrelated.
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/5] Various option help readability improvement suggestions, Max Reitz, 2018/10/15
- [Qemu-block] [PATCH 2/5] chardev: Indent list of chardevs, Max Reitz, 2018/10/15
- [Qemu-block] [PATCH 1/5] option: Make option help nicer to read, Max Reitz, 2018/10/15
- [Qemu-block] [PATCH 3/5] qdev-monitor: Make device options help nicer, Max Reitz, 2018/10/15
- [Qemu-block] [PATCH 4/5] object: Make option help nicer to read, Max Reitz, 2018/10/15
- [Qemu-block] [PATCH 5/5] fw_cfg: Drop newline in @file description, Max Reitz, 2018/10/15