Re: [Qemu-block] [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

[Laurent Vivier]

Le 30/10/2018 à 11:46, Mark Cave-Ayland a écrit :
> On 30/10/2018 06:46, Hervé Poussineau wrote:
> 
>> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
>>> From: Laurent Vivier <address@hidden>
>>>
>>> This is broken as the linux driver seems broken too...
>>>
>>> Co-developed-by: Mark Cave-Ayland <address@hidden>
>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> ---
>>>   hw/audio/Makefile.objs |   1 +
>>>   hw/audio/asc.c         | 446 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>>   include/hw/audio/asc.h |  48 ++++++
>>>   3 files changed, 495 insertions(+)
>>>   create mode 100644 hw/audio/asc.c
>>>   create mode 100644 include/hw/audio/asc.h
>>
>> According to above comment, this device is broken.
>> Is it necessary for Q800 emulation? What happens if you remove it?
> 
> A quick test here shows that I can still boot without it, so it doesn't seem 
> to be
> essential. Laurent, should we remove this from the next revision of the 
> patchset? The
> general consensus seems to be that if a device isn't required (for now) then 
> it
> shouldn't be included.

It can be removed.

I've just checked the kernel and in the case of the Quadra 800 the ASC
is not supported at all.

Thanks,
Laurent