Re: [Qemu-block] [Qemu-devel] [PATCH v2] file-posix: Use error API properly

[Fam Zheng]

On Wed, 10/31 15:51, Markus Armbruster wrote:
> Fam Zheng <address@hidden> writes:
> 
> > Use error_report for situations that affect user operation (i.e.  we're
> > actually returning error), and warn_report/warn_report_err when some
> > less critical error happened but the user operation can still carry on.
> >
> > For raw_normalize_devicepath, add Error parameter to propagate to
> > its callers.
> >
> > Suggested-by: Markus Armbruster <address@hidden>
> > Signed-off-by: Fam Zheng <address@hidden>
> 
> Reviewed-by: Markus Armbruster <address@hidden>
> 
> Kevin, if you'd prefer this to go through my tree, let me know.

Thanks for the review. I'll respin and use error_setg_errno as suggested by
Eric, if it's okay.

Fam