[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 14/15] block: Remove assertions from update_f
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options() |
|
Date: |
Mon, 12 Nov 2018 11:36:23 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote:
>> - assert(qemu_opt_find(opts, BDRV_OPT_CACHE_DIRECT));
>> if (qemu_opt_get_bool_del(opts, BDRV_OPT_CACHE_DIRECT, false)) {
>> *flags |= BDRV_O_NOCACHE;
>> }
>>
>> *flags &= ~BDRV_O_RDWR;
>
> Unrelated to this patch, but isn't BDRV_O_AUTO_RDONLY missing here?
I forgot to mention, but I think you're right here. I'll include this
fix in the next version of the series.
Berto
- Re: [Qemu-block] [PATCH v4 13/15] block: Stop passing flags to bdrv_reopen_queue_child(), (continued)
- [Qemu-block] [PATCH v4 03/15] block: Use bdrv_reopen_set_read_only() in commit_start/complete(), Alberto Garcia, 2018/11/07
- [Qemu-block] [PATCH v4 07/15] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit(), Alberto Garcia, 2018/11/07
- [Qemu-block] [PATCH v4 01/15] block: Add bdrv_reopen_set_read_only(), Alberto Garcia, 2018/11/07
- [Qemu-block] [PATCH v4 10/15] qemu-io: Put flag changes in the options QDict in reopen_f(), Alberto Garcia, 2018/11/07
- [Qemu-block] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options(), Alberto Garcia, 2018/11/07