Re: [Qemu-block] [PATCH 7/6] iotests: Also test I/O over NBD TLS

[Eric Blake]

On 11/19/18 4:40 AM, Daniel P. Berrangé wrote:
> On Sat, Nov 17, 2018 at 08:24:03PM -0600, Eric Blake wrote:
> > Enhance test 233 to also perform I/O beyond the initial handshake.
> >
> > Signed-off-by: Eric Blake <address@hidden>
> > ---
> >
> > Depends on my tweak to 2/6 to suppress an EIO error message
> > on a failed read after NBD_CMD_DISC.
> >
> >   tests/qemu-iotests/233     | 12 +++++++++++-
> >   tests/qemu-iotests/233.out | 10 ++++++++++
> >   2 files changed, 21 insertions(+), 1 deletion(-)
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>

Yay - after dropping patch 2/6 (both your work, and the code I was 
questioning whether to squash in), and instead using your patch for 
making qio return 0 on connection abort after shutdown, this test still 
passes without any extra lines from the server.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org