[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: Skip 233 if certtool not installed
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-block] [PATCH] iotests: Skip 233 if certtool not installed |
Date: |
Wed, 21 Nov 2018 09:32:18 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Nov 20, 2018 at 04:52:41PM -0600, Eric Blake wrote:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>
> On Fedora, libvirt requires libtls-utils to be present, but not qemu.
>
> I'm fine if Kevin wants to pick this up in a pull request related
> to iotests in general; if not, I'll do a pull request through my
> NBD tree in time for -rc3.
>
> tests/qemu-iotests/common.tls | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|