[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevic
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy |
Date: |
Wed, 28 Nov 2018 17:10:01 +0000 |
User-agent: |
Mutt/1.11.0 (2018-11-25) |
On Wed, Nov 21, 2018 at 03:11:55PM +0000, Paul Durrant wrote:
> diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> new file mode 100644
> index 0000000000..dede2d914a
> --- /dev/null
> +++ b/hw/xen/xen-bus.c
> @@ -0,0 +1,125 @@
> +/*
> + * Copyright (c) Citrix Systems Inc.
> + * All rights reserved.
You probably should include:
This work is licensed under the terms of the GNU GPL, version 2 or later.
See the COPYING file in the top-level directory.
As this seems to be a boilerplate used in recent new files, there are
other similair boilerplates.
Also, I think the copyright line should include a year.
> +void xen_bus_init(void)
> +{
> + DeviceState *dev = qdev_create(NULL, TYPE_XEN_BRIDGE);
> +
> + qbus_create(TYPE_XEN_BUS, dev, NULL);
> + qdev_init_nofail(dev);
Will we need a hotplug handler for this bus, like it is done with
TYPE_XENSYSBUS?
The rest looks good,
Thanks,
--
Anthony PERARD
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, (continued)
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Stefano Stabellini, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Eric Blake, 2018/11/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy,
Anthony PERARD <=
[Qemu-block] [PATCH 05/18] xen: add xenstore watcher infratructure, Paul Durrant, 2018/11/21
[Qemu-block] [PATCH 06/18] xen: add grant table interface for XenDevice-s, Paul Durrant, 2018/11/21
[Qemu-block] [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c, Paul Durrant, 2018/11/21
[Qemu-block] [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c, Paul Durrant, 2018/11/21
[Qemu-block] [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice..., Paul Durrant, 2018/11/21
[Qemu-block] [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions..., Paul Durrant, 2018/11/21