[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 05/14] nbd/client: Drop pointless buf variable

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 05/14] nbd/client: Drop pointless buf variable
Date: Wed, 5 Dec 2018 10:49:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/5/18 10:38 AM, Vladimir Sementsov-Ogievskiy wrote:

-    magic = ldq_be_p(buf);
+    magic = be64_to_cpu(magic);

Isn't it better to use be64_to_cpus?

No. We're intentionally getting rid of that because of clang; see commit 

Ok, thanks. In this case it should be safe, but if we decided to avoid these 
functions in general than OK.
Hmm, not in general, but only in nbd.. Strange, why not in qcow2 for ex?,

Peter is working on that - it's a slow process, because he's sending separate patch series per maintainer, so they are not all getting checked in at the same time. But the idea is that once everything is converted, we nuke the *_to_*s variants as unused, and in the meantime, we don't add more uses of it.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]