[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/3] block: remove 'x' prefix from experimental

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 3/3] block: remove 'x' prefix from experimental bitmap APIs
Date: Fri, 7 Dec 2018 10:28:51 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/6/18 1:25 PM, John Snow wrote:
The 'x' prefix was added because we were uncertain of the direction we'd
take for the libvirt API. With the general approach solidified, I feel
comfortable committing to this API for 4.0.

Signed-off-by: John Snow <address@hidden>

+++ b/tests/qemu-iotests/223
@@ -112,9 +112,9 @@ _send_qemu_cmd $QEMU_HANDLE '{"execute":"qmp_capabilities"}' 
  _send_qemu_cmd $QEMU_HANDLE '{"execute":"blockdev-add",
    "arguments":{"driver":"qcow2", "node-name":"n",
      "file":{"driver":"file", "filename":"'"$TEST_IMG"'"}}}' "return"
-_send_qemu_cmd $QEMU_HANDLE '{"execute":"x-block-dirty-bitmap-disable",
+_send_qemu_cmd $QEMU_HANDLE '{"execute":"block-dirty-bitmap-disable",
    "arguments":{"node":"n", "name":"b"}}' "return"
-_send_qemu_cmd $QEMU_HANDLE '{"execute":"x-block-dirty-bitmap-disable",
+_send_qemu_cmd $QEMU_HANDLE '{"execute":"block-dirty-bitmap-disable",
    "arguments":{"node":"n", "name":"b2"}}' "return"
  _send_qemu_cmd $QEMU_HANDLE '{"execute":"nbd-server-start",

No iotests coverage of block-dirty-bitmap-merge. We should fix that as part of this series; separate patch is fine.

I'm glad you remembered to renumber all the 'since' tags to 4.0 (as the new spelling is indeed new to 4.0, not when we introduced the older x- variant).

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]