[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 1/3] error: add error_get_hint

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 1/3] error: add error_get_hint
Date: Tue, 18 Dec 2018 14:50:22 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 11/2/18 10:11 AM, Vladimir Sementsov-Ogievskiy wrote:
Add a function to export error hint - a pair to error_get_pretty. It's
needed to handle errors by hand, where we can't just report it or

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  include/qapi/error.h | 5 +++++
  util/error.c         | 5 +++++
  2 files changed, 10 insertions(+)

I'll have to see how this is used before agreeing to it, but the code itself is fine if the series does indeed warrant it. I wouldn't mind Markus chiming in on the topic, either.

Reviewed-by: Eric Blake <address@hidden>

+const char *error_get_hint(const Error *err)
+    return err->hint ? err->hint->str : NULL;
  void error_report_err(Error *err)
      error_report("%s", error_get_pretty(err));

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]