[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH v6 0/3] block nodes graph visualization

From: Vladimir Sementsov-Ogievskiy
Subject: [Qemu-block] [PATCH v6 0/3] block nodes graph visualization
Date: Fri, 21 Dec 2018 20:09:06 +0300

Hi all!

On the way of backup schemes development (and in general any complicated
developments in Qemu block layer) it would be good to have an ability to print
out graph of block nodes with their permissions.

v6: s/3.1/4.0

01: fix !name -> !*name for checking the result of blk_name
    rename BlockGraph -> XDbgBlockGraph, to not occupy such a
    generic name for x-debug command, correspondingly switch
    dbg_ prefix for functions to xdbg_, add xdbg_ into
    bdrv_get_{xdbg_}block_graph too.

01: - improve documentation and graph node type names
    - parentheses in macro
    - s/hash/graph_nodes
    - add dbg_ prefix to graph functions
    - free leaked gr in dbg_graph_finalize()
    - use uintptr_t and "!= 0" for hash keys, add comment
      about reserved 0 key
    - add const specifier for permissions array and iterator,
      add static on permissions array size
    - fall back to blk_get_attached_dev_id() for block-backend
      nodes if blk_name() returns NULL 
02: - add a-b by Eduardo and r-b by Max
    - change graph node type names (rebase on 01 change)

v3: again, major rework, after long discussion with Max:
   - start creating graph looping through blk's and block jobs, don't use opaque
   - don't export pointers, generate ids instead
   (graphical representation didn't significantly changed, you can look at the
    picture, attached to v2 cover-letter)

v2: major rework: Identifying non-bds nodes by their description was a bad idea,
descriptions are not guaranteed to be different for different nodes. So, the 
way is use pointer to identify them. And to be unique, let's use pointers to
identify all the nodes in the graph. As additional benefit, we have pointers for
each node, which is good for debugging (imagine a gdb session).

Vladimir Sementsov-Ogievskiy (3):
  qapi: add x-debug-query-block-graph
  scripts: add render_block_graph function for QEMUMachine
  not-for-commit: example of new command usage for debugging

 qapi/block-core.json           | 108 ++++++++++++++++++++++++
 include/block/block.h          |   1 +
 include/sysemu/block-backend.h |   2 +
 block.c                        | 148 +++++++++++++++++++++++++++++++++
 block/block-backend.c          |   5 ++
 blockdev.c                     |   5 ++
 scripts/render_block_graph.py  | 120 ++++++++++++++++++++++++++
 tests/qemu-iotests/222         |   2 +
 8 files changed, 391 insertions(+)
 create mode 100755 scripts/render_block_graph.py


reply via email to

[Prev in Thread] Current Thread [Next in Thread]