[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table |
|
Date: |
Fri, 11 Jan 2019 11:02:22 +0100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 10.01.2019 um 20:18 hat Eric Blake geschrieben:
> Patches speak louder than words. This is my counter-proposal to
> Leonid's thread on how best to respresent the S_*iB macros in units.h,
> where my proposal is that we don't need them at all. (hence my subject
> line, even though it is completely unrelated to the series)
>
> True, my diffstat is even bigger, but I think it is more maintainable
> in the long run (if calling QemuOpts maintainable is even appropriate).
We're wasting too much time on this stuff. But anyway, I consider this
part of Markus' maintainership area, and if he likes to merge it, I
don't mind. I did not actually review this in detail.
Acked-by: Kevin Wolf <address@hidden>
- Re: [Qemu-block] [PATCH v3 2/6] block: Take advantage of QemuOpt default integers, (continued)
- [Qemu-block] [PATCH v3 3/6] Revert "vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE", Eric Blake, 2019/01/10
- [Qemu-block] [PATCH v3 4/6] qemu: Prefer '(x * MiB)' over 'S_xiB', Eric Blake, 2019/01/10
- [Qemu-block] [PATCH v3 5/6] Revert "include: Add a comment to explain the origin of sizes' lookup table", Eric Blake, 2019/01/10
- [Qemu-block] [PATCH v3 6/6] Revert "include: Add a lookup table of sizes", Eric Blake, 2019/01/10
- Re: [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table, Eric Blake, 2019/01/10
- Re: [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table,
Kevin Wolf <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table, no-reply, 2019/01/14