[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH 15/15] ui/console: Add "ui/pixelformat.h" to
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-block] [RFC PATCH 15/15] ui/console: Add "ui/pixelformat.h" to declare PixelFormat |
Date: |
Mon, 14 Jan 2019 13:35:31 +0100 |
User-agent: |
NeoMutt/20180716 |
On Mon, Jan 14, 2019 at 11:24:14AM +0100, Philippe Mathieu-Daudé wrote:
> On 1/11/19 6:32 PM, Paolo Bonzini wrote:
> > On 11/01/19 15:08, Philippe Mathieu-Daudé wrote:
> >> PixelFormat is used by "ui/console.h" and by "ui/qemu-pixman.h".
> >
> > ui/console.h already includes ui/qemu-pixman.h, just move it there?
>
> That was my first though but then noticed pixman seems a bit
> different/unrelated. If Gerd is OK I will do it. (I should have written
> that in the commit).
console depends on pixman anyway, so that move would be fine.
BTW: Should not be that hard to remove PixelFormat altogether, or move
the bits which are still needed to vnc which is the only user left
(beside deprecated sdl1 which should go away soon).
cheers,
Gerd
[Qemu-block] [PATCH 14/15] ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
[Qemu-block] [PATCH 13/15] ui/console: Remove QemuDmaBuf from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
[Qemu-block] [PATCH 12/15] ui/console: Remove MouseTransformInfo from qemu/typedefs.h, Philippe Mathieu-Daudé, 2019/01/11
[Qemu-block] [PATCH 11/15] audio: Remove AudioState from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
[Qemu-block] [PATCH 09/15] hw/i386: Remove PCMachineClass from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
[Qemu-block] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11