[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 10/19] nbd/client: Split out nbd_send_one_met

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v3 10/19] nbd/client: Split out nbd_send_one_meta_context()
Date: Tue, 15 Jan 2019 09:55:28 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/15/19 9:52 AM, Vladimir Sementsov-Ogievskiy wrote:

>>>> -nbd_opt_meta_request(const char *context, const char *export) "Requesting 
>>>> to set meta context %s for export %s"
>>>> +nbd_opt_meta_request(const char *optname, const char *context, const char 
>>>> *export) "Requesting %s %s for export %s"
>>> Hmm, you forget nbd_opt_lookup()
>> Where? The updated trace point at [2] has nbd_opt_lookup() for
>> determining optname.
> Your morning is my evening)
> Yes, it's ok, and in the next patch too. But you usually trace both number + 
> lookup-string,
> and here only string. Is there a reason to?

I didn't see any added value in tracing the number, since the trace
point can only happen on one of two opt values (the number is more
important when the opt value can be anything, including one that does
not have a corresponding string name compiled in).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]