[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext duri
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize() |
Date: |
Thu, 17 Jan 2019 14:24:10 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote:
> The x-blockdev-set-iothread command is for low-level tests so I don't
> expect users to invoke it.
As I said in a different e-mail maybe this is not necessary then.
> This patch series makes virtio-blk and virtio-scsi more robust,
> although I haven't checked what happens if the drive is attached to a
> different IOThread than the device - will the switchover work?
You mean if you use x-blockdev-set-iothread with a drive and then attach
it to a device using a different thread? That seems to work (with my
patch).
> What I'm unclear about is why fdc, ide, usb-msd, and nvme should worry
> about IOThreads/AioContext in .realize() since they don't support it
> in their data path. What happens when you submit I/O requests to
> devices configured like this? I guess they would crash or hit
> assertion failures since they invoke blk_aio_*() APIs from outside the
> appropriate AioContext.
>
> Maybe fdc and friends should forbid this scenario:
Yeah, that seems like a simple solution.
Berto
- [Qemu-block] [PATCH v2 0/6] Acquire the AioContext during _realize(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 5/6] block: Acquire the AioContext in ide_dev_initfn(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 6/6] block: Acquire the AioContext in usb_msd_storage_realize(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 4/6] block: Acquire the AioContext in nvme_realize(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 3/6] block: Acquire the AioContext in floppy_drive_realize(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 1/6] block: Acquire the AioContext in virtio_blk_device_realize(), Alberto Garcia, 2019/01/14
- [Qemu-block] [PATCH v2 2/6] block: Acquire the AioContext in scsi_*_realize(), Alberto Garcia, 2019/01/14
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize(), Stefan Hajnoczi, 2019/01/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize(),
Alberto Garcia <=
Re: [Qemu-block] [PATCH v2 0/6] Acquire the AioContext during _realize(), Kevin Wolf, 2019/01/18