[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 07/18] tests/multiboot: Improve portability b
From: |
Kamil Rytarowski |
Subject: |
Re: [Qemu-block] [PATCH v2 07/18] tests/multiboot: Improve portability by searching bash in the $PATH |
Date: |
Tue, 29 Jan 2019 19:10:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 29.01.2019 18:53, Philippe Mathieu-Daudé wrote:
> Bash is not always installed as /bin/bash. In particular on OpenBSD,
> the package installs it in /usr/local/bin.
> Use the 'env' shebang to search bash in the $PATH.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Kamil Rytarowski <address@hidden>
> ---
> tests/multiboot/run_test.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/multiboot/run_test.sh b/tests/multiboot/run_test.sh
> index 6c33003e71..a88e423992 100755
> --- a/tests/multiboot/run_test.sh
> +++ b/tests/multiboot/run_test.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#! /usr/bin/env bash
>
> # Copyright (c) 2013 Kevin Wolf <address@hidden>
> #
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 02/18] configure: Disable W^X on OpenBSD, (continued)
- [Qemu-block] [PATCH v2 02/18] configure: Disable W^X on OpenBSD, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 03/18] tests/vm/openbsd: Disable the W^X protection on the build partition, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 04/18] ahci-test: Add dependency to qemu-img tool, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 05/18] qemu-iotests: Add dependency to qemu-nbd tool, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 07/18] tests/multiboot: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 06/18] qemu-iotests: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 08/18] tests/bios-tables: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-block] [RFC PATCH v2 10/18] qemu-iotests: Ensure GNU sed is used, Philippe Mathieu-Daudé, 2019/01/29