qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v13 3/3] qcow2: list of bitmaps new test 242


From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v13 3/3] qcow2: list of bitmaps new test 242
Date: Wed, 6 Feb 2019 08:33:10 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 2/6/19 5:58 AM, Andrey Shinkevich wrote:

>> +
>> +def add_bitmap(bitmap_number, persistent, disabled):
>> +    granularity = 2**(13 + bitmap_number)
> 
> I wish I wrote:
>      granularity = 1 << (13 + bitmap_number)

Sure, that's easy to squash in.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]