[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 2/3] Acceptance tests: depend on qemu-img
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-block] [PATCH v4 2/3] Acceptance tests: depend on qemu-img |
Date: |
Thu, 7 Feb 2019 19:17:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
FWIW, Cc'ing qemu-img maintainers.
On 2/7/19 7:00 PM, Cleber Rosa wrote:
> Tests using the avocado.utils.vmimage library make use of qemu-img,
> and because it makes sense to use the version matching the rest of the
> source code, let's make sure it gets built.
>
> Its selection, instead of a possible qemu-img binary installed system
> wide, is already dealt with by the change that adds the build dir to
> the PATH during the test execution.
>
> This is based on the same work for qemu-iotests, and suggested by its
> author:
>
> - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html
>
> CC: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index b39e989f72..9a2fb94f4a 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -1111,7 +1111,7 @@ $(TESTS_RESULTS_DIR):
>
> check-venv: $(TESTS_VENV_DIR)
>
> -check-acceptance: check-venv $(TESTS_RESULTS_DIR)
> +check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF)
> $(call quiet-command, \
> $(TESTS_VENV_DIR)/bin/python -m avocado \
> --show=$(AVOCADO_SHOW) run
> --job-results-dir=$(TESTS_RESULTS_DIR) \
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v4 2/3] Acceptance tests: depend on qemu-img,
Philippe Mathieu-Daudé <=