Re: [Qemu-block] [RFC PULL 0/6] Block sgarzare test patches

[Stefano Garzarella]

On Tue, Feb 12, 2019 at 6:04 PM Peter Maydell <address@hidden> wrote:
>
> On Tue, 12 Feb 2019 at 14:12, Stefan Hajnoczi <address@hidden> wrote:
> > ----------------------------------------------------------------
> > Block pull request for testing
> >
> > Peter hit a virtio-blk-test failure caused by the new DISCARD/WRITE_ZEROES
> > patches that Stefano and I have been unable to reproduce.  Here are the 
> > patches
> > so they can be tested again in Peter's environment.
> >
> > ----------------------------------------------------------------
>
> x86-64 host seems to be a bit random about whether it reproducibly
> fails (it failed in the test merge builds but not when I run the
> test program by hand) but aarch64 host seems more definitely
> fails-every-time:
>
> address@hidden:~/qemu/build/all$
> QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 strace -tt -f -o
> ~/strace.log  tests/virtio-blk-test
> /ppc64/virtio/blk/pci/basic: **
> ERROR:/home/pm215/qemu/tests/virtio-blk-test.c:272:test_basic:
> assertion failed (status == 0): (1 == 0)
> Aborted (core dumped)
>
> The strace.log from that is at
> http://people.linaro.org/~peter.maydell/strace.log
> (3.6MB file; the -f means it will have the trace for
> both the test binary and the QEMU process it spawns).
>
> thanks
> -- PMM

I found the error. I forgot the endianness in the test, so now it
works on ppc64 guest and x86_64 host.
Maybe the randomness of the fails was the different endianness between
guest and host.

I'll send a v5 of the series with the fix.

Thanks and sorry for that,
Stefano