Re: [Qemu-block] [Qemu-devel] [PATCH v4] drive-mirror: add incremental mode

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4] drive-mirror: add incremental mode
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
978066d631 drive-mirror: add incremental mode

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#65: FILE: block/mirror.c:822:
+static void coroutine_fn mirror_dirty_init_incremental(MirrorBlockJob *s, 
Error **errp)

ERROR: space prohibited after that open parenthesis '('
#199: FILE: blockdev.c:3773:
+    if ( !bitmap_name && (sync == MIRROR_SYNC_MODE_INCREMENTAL)) {

total: 1 errors, 1 warnings, 236 lines checked

Commit 978066d631a9 (drive-mirror: add incremental mode) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden