Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v5 00/10] virtio-blk: add DISCARD and WRITE_ZEROES 
features
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   1e36232994..1c5d9d8f11  master     -> master
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4e387bff7b tests/virtio-blk: add test for DISCARD command
9dbf66647f tests/virtio-blk: add test for WRITE_ZEROES command
1e74575a2e tests/virtio-blk: add virtio_blk_fix_dwz_hdr() function
0677a06531 tests/virtio-blk: change assert on data_size in virtio_blk_request()
f2d45c1a14 virtio-blk: add DISCARD and WRITE_ZEROES features
7cc46c25d2 virtio-blk: set config size depending on the features enabled
26f46a5550 virtio-net: make VirtIOFeature usable for other virtio devices
23b07b39fb virtio-blk: add "discard" and "write-zeroes" properties
9d6734a0fe virtio-blk: add host_features field in VirtIOBlock
97427f4d38 virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

=== OUTPUT BEGIN ===
1/10 Checking commit 97427f4d38a6 (virtio-blk: add acct_failed param to 
virtio_blk_handle_rw_error())
2/10 Checking commit 9d6734a0fed5 (virtio-blk: add host_features field in 
VirtIOBlock)
3/10 Checking commit 23b07b39fb93 (virtio-blk: add "discard" and "write-zeroes" 
properties)
4/10 Checking commit 26f46a5550f8 (virtio-net: make VirtIOFeature usable for 
other virtio devices)
5/10 Checking commit 7cc46c25d2e3 (virtio-blk: set config size depending on the 
features enabled)
6/10 Checking commit f2d45c1a148c (virtio-blk: add DISCARD and WRITE_ZEROES 
features)
7/10 Checking commit 0677a0653115 (tests/virtio-blk: change assert on data_size 
in virtio_blk_request())
8/10 Checking commit 1e74575a2e89 (tests/virtio-blk: add 
virtio_blk_fix_dwz_hdr() function)
ERROR: do not initialise globals to 0 or NULL
#24: FILE: tests/virtio-blk-test.c:52:
+const bool host_is_big_endian = false;

total: 1 errors, 0 warnings, 41 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/10 Checking commit 9dbf66647f0b (tests/virtio-blk: add test for WRITE_ZEROES 
command)
10/10 Checking commit 4e387bff7bb9 (tests/virtio-blk: add test for DISCARD 
command)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden