[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error reporting for
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object |
|
Date: |
Tue, 19 Feb 2019 17:14:09 +0100 |
|
User-agent: |
NeoMutt/20180716 |
On Tue, Feb 19, 2019 at 11:46:09AM +0000, Daniel P. Berrangé wrote:
> Error reporting for user_creatable_add_opts_foreach was changed so that
> it no longer called 'error_report_err' in:
>
> commit 7e1e0c11127bde81cff260fc6859690435c509d6
> Author: Markus Armbruster <address@hidden>
> Date: Wed Oct 17 10:26:43 2018 +0200
>
> qom: Clean up error reporting in user_creatable_add_opts_foreach()
>
> Some callers were updated to pass in "&error_fatal" but all the ones in
> qemu-img were left passing NULL. As a result all errors went to
> /dev/null instead of being reported to the user.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> qemu-img.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Stefano Garzarella <address@hidden>