[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] iotests: handle TypeError for Python3 in tes
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2] iotests: handle TypeError for Python3 in test 242 |
Date: |
Fri, 22 Feb 2019 08:53:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/22/19 5:26 AM, Andrey Shinkevich wrote:
> The data type for bytes in Python3 differs from the one in Python2.
> Those cases should be managed separately.
>
> v1:
> In the first version, the TypeError in Python3 was handled as the
> exception.
> Discussed in the e-mail thread with the Message ID:
> <address@hidden>
This paragraph belongs...
>
> Signed-off-by: Andrey Shinkevich <address@hidden>
> Reported-by: Kevin Wolf <address@hidden>
> ---
...here, after the --- marker. It is useful to reviewers, but does not
need to land in the long-term git history (a year from now, we won't
care if it was v2 or v10 that landed, nor how it changed from the
versions that didn't land). I can clean it up on staging.
Reviewed-by: Eric Blake <address@hidden>
Will stage through my NBD tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org